Uploaded image for project: 'HERAS-AF XACML Core'
  1. XACMLCORE-186

Broken equals implementation for org.herasaf.xacml.core.simplePDP.initializers.PolicyCombiningAlgorithmsJAXBInitializer

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects versions: 1.0.0-M2
    • Fix versions: 1.0.0.M3
    • Components: Initializers
    • Labels:
      None
    • Number of Attachments:
      0
    • Number of Comments:
      2
    • Sprint:

      Description

      Equals implementation compares against wrong class name (PolicyCombiningAlgorithm), and will thus never yield true.

      Consider to remove all equals() and hashCode() from Initializers (as they are not value types nor used as value types).

      Relevant snippet:

      /**

      {@inheritDoc}

      */
      public boolean equals(Object obj) {
      if (obj == null)

      { return false; }

      if (!(obj instanceof PolicyCombiningAlgorithm)) { return false; }

      return hashCode() == obj.hashCode();
      }

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1 hour
                1h
                Remaining:
                Remaining Estimate - 1 hour
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified