Support multiple AttributeValues

Description

Currently only AttributeValues with one value are supported.
To handle multiple AttributeValues the following changes have to be done:

The convert(...) method of the DataTypeAttributes must take the AttributeValue itself and not a string anymore:

01.10.2012:
Florian and René have discussed the necessary changes. These are listed below:

  • The interface DataTypeAttribute<E> must be changed at convert-Method from:

    to:

  • All implementations of the interface have to be adjusted, so that they accordingly convert the 'List<?> jaxbRepresentation'. These are 16 implementations.

  • The AttributeDesignatorType must be refactored at addAndConvertAttrValue. Remove the 'get(0)' and the cast.

    The same has to be done at AttributeValueType.handle(...) and TargetMatcherImpl.match(...)

  • A howto should be written for the handling of custom "complex datatypes"

  • All according Unit tests need to be refactored. Integration Tests should be written that prove the exact behaviour

Environment

None

Activity

Show:
RenéR
December 5, 2012, 7:28 PM

Hi,

We will spend some days during our christmas holidays and will look at the patches that have been supplied so far.
If the patches fit into our codebase we will directly apply them to our trunk.
Maybe we will ask back some questions or give feedback during that time.

You can expect that the patches will be reviewed and hopefully available in our trunk by latest January 6th 2013.
If possible we would then also release 1.0.0.M4.

Best regards,
René and Florian

Florian Huonder
January 7, 2013, 8:35 AM

Might conflict with XACMLCORE-202.
Has to be taken into account when integrating the patch.

Colm O hEigeartaigh
January 8, 2013, 1:55 PM

Here is a revised patch based on the original patch, that takes into account subsequent changes to the way JAXBContext is used.

In particular, SimplePDPConfiguration has a list of Class<?> instances rather than a list of Strings corresponding to package names.

Colm.

Florian Huonder
January 8, 2013, 2:19 PM

Great, thanks a lot.

Florian Huonder
February 27, 2013, 1:17 PM

to be reviewed.

Assignee

Florian Huonder

Reporter

Florian Huonder

Labels

None

Time tracking

0m

Time remaining

16h

Components

Fix versions

Priority

Major
Configure